Skip to content

Conversation

@maarten-ic
Copy link
Collaborator

Fixes #84

@imbeauf
Copy link

imbeauf commented Dec 4, 2025

I have made a preliminary test and yes it seems to work as expected, thank you very much !
Just a question about the mention of DD 4.1.0 at this stage:

imas process-db-analysis imas-db-analysis.json.gz --csv output.csv
[12/04/25 11:55:24] INFO Parsing data dictionary version 4.1.0 dd_zip.py:89
[12/04/25 11:55:25] INFO Using Data Dictionary version 4.1.0. db_analysis.py:22

Why is this appearing, because I think I didn't ask for conversion of any of the analyzed datasets ?

@maarten-ic
Copy link
Collaborator Author

I have made a preliminary test and yes it seems to work as expected, thank you very much ! Just a question about the mention of DD 4.1.0 at this stage:

imas process-db-analysis imas-db-analysis.json.gz --csv output.csv
[12/04/25 11:55:24] INFO Parsing data dictionary version 4.1.0 dd_zip.py:89
[12/04/25 11:55:25] INFO Using Data Dictionary version 4.1.0. db_analysis.py:22

Why is this appearing, because I think I didn't ask for conversion of any of the analyzed datasets ?

This is actually not relevant when creating the csv files: the IDS paths are not transformed at all by the script.

For the terminal output the script determines which nodes in an IDS are used and which are not. It needs to load a DD version for this, and the default version is the latest available (4.1.0) unless an IMAS_VERSION environment variable is set.

I just pushed a fix to the branch to move the logging statements, so they are only shown when relevant.

@maarten-ic maarten-ic marked this pull request as ready for review December 5, 2025 08:42
@maarten-ic maarten-ic requested a review from imbeauf December 5, 2025 08:42
Copy link
Collaborator

@olivhoenen olivhoenen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@olivhoenen olivhoenen merged commit bade438 into iterorganization:develop Dec 10, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Provide CSV output and frequency among datasets statistics

3 participants