Include matchMedia API in responsive-design workload #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: issackjohn <117320405+issackjohn@users.noreply.github.com>
Co-authored-by: issackjohn <117320405+issackjohn@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Investigate if we could include matchMedia somewhere in the responsive-design workload
Include matchMedia API in responsive-design workload
May 27, 2025
issackjohn
requested changes
May 27, 2025
Owner
issackjohn
left a comment
issackjohn
left a comment
There was a problem hiding this comment.
You were supposed to make changes to experimental/responsive-design workload
Author
I've moved the matchMedia implementation to the experimental/responsive-design workload as requested. The changes now include:
The implementation has been tested and builds successfully. You can see the changes in the latest commit. |
Copilot stopped work on behalf of
issackjohn due to an error
May 27, 2025 21:16
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR incorporates the matchMedia API into the Speedometer benchmark's responsive-design workload, making the benchmark more representative of modern web applications that use this API for responsive design.
Changes
matchMedia APIto the required browser features list inmain.jsComponentBaseclass to use matchMedia for responsive design alongside existing window resize events(max-width: 767px)(min-width: 768px) and (max-width: 1199px)addEventListener) and older (addListener) methods for media query change notificationsBenefits
Testing
The implementation has been tested manually to ensure that components correctly respond to media query changes.
Fixes #25.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.