[pull] dev from KelvinTegelaar:dev #68
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed URL structure for Add and Remove service principal alerts: - Updated path from /tenant/administration/enterprise-apps to /tenant/administration/applications/enterprise-apps - Changed query parameter from customerId=?customerId= to tenantFilter= with tenant default domain - Fixes incorrect URL generation that was using double customerId parameter Co-authored-by: Zacgoose <107489668+Zacgoose@users.noreply.github.com>
Corrected the IntroText to say "has been removed" instead of "has been added" for the Remove service principal operation to match the actual action being performed. Co-authored-by: Zacgoose <107489668+Zacgoose@users.noreply.github.com>
…ert-url Fix service principal alert URL structure
Added overwrite toggle for transport rule standard
Adds duplicate RowKey checks to prevent race conditions when creating scheduled tasks. Enhances rerun protection logic in Push-ExecScheduledCommand to avoid duplicate executions within recurrence intervals. Refines orchestrator task state transitions and filtering for stuck tasks. Improves logging and filtering for scheduled item listing, and updates Test-CIPPRerun to support custom intervals and base times for scheduled tasks.
Backups are now stored as blobs in Azure Storage with table entities referencing the blob URLs, improving scalability and performance. The backup listing, creation, and retention cleanup functions have been updated to handle blob-based backups, including proper cleanup of both blob files and table entries. Restore logic is enhanced to fetch and parse blob content, and restoration tasks now provide more detailed feedback and error handling. These changes modernize the backup/restore pipeline and improve reliability for large backup data.
Enterprise Apps link in new service principal alerts are not in the correct format
Fix: Fix app protection policies not being listed
Apparently, I removed this a while ago while doing some other stuff...
Refactors Add-CIPPApplicationPermission to batch-create missing service principals and apply app role assignments using Microsoft Graph bulk requests. This improves efficiency and error handling when processing multiple permissions and service principals.
Added informational logging to Add-CIPPApplicationPermission for better traceability. Updated Invoke-ExecCPVRefresh to nest InstanceId under Metadata in the response body for improved response structure.
- Update product display names in ExcludeSkuList.JSON to match authoritative license data. - Implemented syncing logic in Update-LicenseSKUFiles.ps1 to automate updates.
Feat: Support removal of multiple IPs and locations
Chore: Sync product names in ExcludeSkuList.JSON
Add-CIPPDbItem now supports pipeline input for memory-efficient streaming, improved batch processing, and automatic count recording via -AddCount. Updated related cache scripts to use streaming and batch features, reducing memory usage and simplifying code. Added Set-CIPPDbCacheTestData.ps1 for generating large test datasets. Enhanced Add-CIPPAzDataTableEntity with performance logging.
…IPPDbItem Eliminated detailed timing and debug output from Add-CIPPAzDataTableEntity.ps1 to reduce log verbosity and improve performance. Commented out Write-Debug statements in Add-CIPPDbItem.ps1 and added property selection to Get-CIPPAzDataTableEntity for efficiency.
Improved client secret retrieval logic and error messaging in Invoke-ExecTokenExchange. Added organization and user info to Invoke-ExecListAppId response. Implemented retry logic for Key Vault secret retrieval in Get-CippKeyVaultSecret. Enhanced error normalization for AADSTS650051 in Get-NormalizedError. Minor code style and comment cleanups.
This update retrieves the application's web redirect URIs and adds a new redirect URI based on the current request if it is not already present. The change ensures the application's redirect URIs are kept up to date automatically during execution.
Wrapped the redirect URI update logic in a try/catch block to handle potential failures when updating application redirect URIs. Added logging for both successful and failed update attempts to improve troubleshooting and reliability.
Replaces multiple Microsoft Graph API calls with a single batch request to retrieve organization and domain information when adding a tenant. Adds logic to trigger a CPV permissions refresh for the new tenant by starting the appropriate orchestrator.
The success message now informs users that a permission refresh is queued and the tenant will be available shortly, providing clearer feedback after adding a tenant.
After updating the refresh token, immediately set it as an environment variable to make it available for subsequent operations. This applies to both the main tenant and additional tenants, ensuring the new token is accessible without delay.
Introduces a -Force switch to the Get-CIPPAuthentication function, allowing environment variables to be overwritten even if they are already set. Without the switch, existing environment variables are skipped. This is to avoid rate limits with the key vault api when we are adding separate tenants.
Replaces the immediate call to Start-UpdatePermissionsOrchestrator with logic to queue and start the permissions update orchestrator specifically for the partner tenant after updating the refresh token. Adds error handling and logging for orchestrator startup.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )