Skip to content

Support token existing as query param in ResetPW#1948

Merged
sjd210 merged 7 commits intomainfrom
feature/reset-password-qparam-token
Feb 9, 2026
Merged

Support token existing as query param in ResetPW#1948
sjd210 merged 7 commits intomainfrom
feature/reset-password-qparam-token

Conversation

@jacbn
Copy link
Copy Markdown
Contributor

@jacbn jacbn commented Jan 29, 2026

The old route is being maintained for the meantime.

@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 29, 2026

Codecov Report

❌ Patch coverage is 50.00000% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 42.49%. Comparing base (203fc43) to head (3a80562).
⚠️ Report is 81 commits behind head on main.

Files with missing lines Patch % Lines
src/mocks/handlers.ts 0.00% 3 Missing ⚠️
...c/app/components/handlers/PasswordResetHandler.tsx 83.33% 1 Missing ⚠️
src/test/pages/PasswordResetHandler.cy.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1948      +/-   ##
==========================================
+ Coverage   42.46%   42.49%   +0.03%     
==========================================
  Files         575      575              
  Lines       24521    24557      +36     
  Branches     8071     8118      +47     
==========================================
+ Hits        10413    10436      +23     
- Misses      13442    13455      +13     
  Partials      666      666              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Contributor

@sjd210 sjd210 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewing this branch has reminded me of some strange behaviour with password managers being unable to set the password-confirm field since it's initially disabled. It's slightly annoying, but definitely separate from this - I'll make a card for it.

The changes themselves here look good 👍

@sjd210 sjd210 merged commit e721398 into main Feb 9, 2026
10 checks passed
@sjd210 sjd210 deleted the feature/reset-password-qparam-token branch February 9, 2026 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants