Support token existing as query param in ResetPW#1948
Merged
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1948 +/- ##
==========================================
+ Coverage 42.46% 42.49% +0.03%
==========================================
Files 575 575
Lines 24521 24557 +36
Branches 8071 8118 +47
==========================================
+ Hits 10413 10436 +23
- Misses 13442 13455 +13
Partials 666 666 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…-qparam-token [VRT] Update baselines for feature/reset-password-qparam-token
sjd210
approved these changes
Feb 9, 2026
Contributor
sjd210
left a comment
There was a problem hiding this comment.
Reviewing this branch has reminded me of some strange behaviour with password managers being unable to set the password-confirm field since it's initially disabled. It's slightly annoying, but definitely separate from this - I'll make a card for it.
The changes themselves here look good 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The old route is being maintained for the meantime.