Add content error for non-absolute width SVGs#753
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #753 +/- ##
==========================================
- Coverage 38.25% 38.24% -0.01%
==========================================
Files 541 541
Lines 23664 23670 +6
Branches 2822 2824 +2
==========================================
Hits 9053 9053
- Misses 13735 13741 +6
Partials 876 876 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
axlewin
approved these changes
Feb 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checks all Media for SVGs containing non-absolute width (%-based width, or no width at all) via a regex match and adds it as a non-critical content error if so.
Since we don't process SVGs as content, this is the best way of dealing with this that I can think of. This means there will be no warning for SVGs not yet used as a
"src", and multiple warnings for a single SVG used multiple times - but both of these are rare cases so I think it's okay.