[NX-OS] Refactor BGP ownership marker to per-VRF peer templates#394
Open
felix-kaestner wants to merge 1 commit into
Open
[NX-OS] Refactor BGP ownership marker to per-VRF peer templates#394felix-kaestner wants to merge 1 commit into
felix-kaestner wants to merge 1 commit into
Conversation
Previously, a single __operator-managed__ peer template was written into every BGP domain. Since NX-OS only supports peer templates under the default VRF domain, this was incorrect for non-default VRFs. Write a unique marker per managed BGP domain into the default VRF domain using the pattern __operator-managed--<vrfName>__. This allows the operator to track all managed instances and on deletion determine whether it is safe to remove the global BGP instance. On deletion of a non-default VRF domain, the marker is removed and the domain deleted. For the default VRF, the domain is atomically replaced with only the remaining markers as the default VRF unconditionally always exists in a bgp instance, even when only non-default VRFs are configured. The global BGP instance is only deleted when no ownership markers remain. Signed-off-by: Felix Kästner <felix.kaestner@sap.com>
Merging this branch will decrease overall coverage
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, a single operator-managed peer template was written into every BGP domain. Since NX-OS only supports peer templates under the default VRF domain, this was incorrect for non-default VRFs.
Write a unique marker per managed BGP domain into the default VRF domain using the pattern operator-managed--. This allows the operator to track all managed instances and on deletion determine whether it is safe to remove the global BGP instance.
On deletion of a non-default VRF domain, the marker is removed and the domain deleted. For the default VRF, the domain is atomically replaced with only the remaining markers as the default VRF unconditionally always exists in a bgp instance, even when only non-default VRFs are configured. The global BGP instance is only deleted when no ownership markers remain.