Fix stale error leak in EnsureBGP causing "gnmiext: nil"#386
Merged
Conversation
When the BGP domain does not exist on the device (first-time config) and the ASN uses plain notation, the outer err variable retained the ErrNil value from the domain GetConfig call. Neither switch case for AS format fired, so err was never reassigned and leaked to the caller. Scope error handling into each switch case so that the shared err variable is no longer carried across unrelated operations. Also skip the router-ID conflict check when the existing domain has an empty router-ID, avoiding a false-positive mismatch error. Signed-off-by: Felix Kästner <felix.kaestner@sap.com>
felix-kaestner
force-pushed
the
fix/bgp-nil
branch
from
a5fa0a3 to
c66c8d0
Compare
Merging this branch will not change overall coverage
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the BGP domain does not exist on the device (first-time config) and the ASN uses plain notation, the outer err variable retained the ErrNil value from the domain GetConfig call. Neither switch case for AS format fired, so err was never reassigned and leaked to the caller.
Scope error handling into each switch case so that the shared err variable is no longer carried across unrelated operations.
Also skip the router-ID conflict check when the existing domain has an empty router-ID, avoiding a false-positive mismatch error.