feat(iosxr): add support for 802.1Q and 802.1ad subinterfaces#340
Open
sven-rosenzweig wants to merge 1 commit intomainfrom
Open
feat(iosxr): add support for 802.1Q and 802.1ad subinterfaces#340sven-rosenzweig wants to merge 1 commit intomainfrom
sven-rosenzweig wants to merge 1 commit intomainfrom
Conversation
5da6559 to
57bb46e
Compare
57bb46e to
2208a91
Compare
54a3ee8 to
ff0fc3e
Compare
Add support for configuring subinterfaces on both physical and bundle interfaces. Refactor code by removing the unused ExtractVlan method and renaming/refactoring ExtractBundleInterface to extract the subinterface ID generically. Clean up IPv4 network configuration by introducing a helper function. Signed-off-by: Sven Rosenzweig <sven.rosenzweig@sap.com>
ff0fc3e to
50c8397
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for configuring subinterfaces on both physical and
bundle interfaces.
Refactor code by removing the unused ExtractVlan method and
renaming/refactoring ExtractBundleInterface to extract the
subinterface ID generically.
Clean up IPv4 network configuration by introducing a helper
function.