state: Check deploy prefix 0xEF before gas cost#1552
Merged
Conversation
When checking new code deployment requirements, check the forbidden 0xEF prefix before checking the by-byte deployment cost. This help with future EIP-8037 implementation.
There was a problem hiding this comment.
Pull request overview
Reorders contract-creation validation in the state test host so the EIP-3541 “0xEF prefix” rejection happens before charging the per-byte code deployment gas cost, aligning behavior with upcoming work (e.g., EIP-8037-related handling).
Changes:
- Move the EIP-3541 0xEF-prefix rejection check to occur before computing/charging deployment gas.
- Use
bytes_view::starts_with()instead of manualcode[0]indexing for the prefix check.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+305
to
+307
| // Reject new contract code starting with the 0xEF byte (EIP-3541). | ||
| if (m_rev >= EVMC_LONDON && code.starts_with(0xEF)) | ||
| return evmc::Result{EVMC_CONTRACT_VALIDATION_FAILURE}; |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1552 +/- ##
=======================================
Coverage 96.97% 96.97%
=======================================
Files 163 163
Lines 14449 14449
Branches 3383 3383
=======================================
Hits 14012 14012
Misses 307 307
Partials 130 130
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When checking new code deployment requirements, check the forbidden 0xEF prefix before checking the by-byte deployment cost. This help with future EIP-8037 implementation.