Skip to content

crypto: Fix incorrect docstrings in BN254 and KZG pairing helpers #1548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chfast merged 1 commit into from
May 27, 2026
Merged

crypto: Fix incorrect docstrings in BN254 and KZG pairing helpers #1548

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion lib/evmone_precompiles/kzg.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,8 @@ blst_p1_affine add_or_double(const blst_p1_affine& p, const blst_p1& q) noexcept
bool pairings_verify(const blst_p1_affine& a1, const blst_p1_affine& b1) noexcept
{
blst_fp12 left;
// Uses precomputed Miller loop lines for the G2 generator.
// Runs the Miller loop against the G2 generator (no precomputed lines).
// TODO: Precompute lines for G2_GEN and use blst_miller_loop_lines() like the [s]₂ side.
blst_aggregated_in_g1(&left, &a1);
// Uses precomputed Miller loop lines for KZG_SETUP_G2_1 ([s]₂).
blst_fp12 right;
Expand Down
2 changes: 1 addition & 1 deletion lib/evmone_precompiles/pairing/bn254/pairing.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ namespace evmmax::bn254
namespace
{
/// Multiplies `fr` (Fq12) values by sparse `v` (Fq12) value of the form
/// [[t[0] * y, 0, 0],[t[1] * x, t[0], 0]] where `v` coefficients are from Fq2
/// [[t[0] * y, 0, 0],[t[1] * x, t[2], 0]] where `v` coefficients are from Fq2
constexpr void multiply_by_lin_func_value(
Fq12& fr, std::array<Fq2, 3> t, const Fq& x, const Fq& y) noexcept
{
Expand Down