crypto: Trivial reuse of computed values in pairing helpers#1542
Merged
Conversation
This reuses already computed terms in trivial cases in pairing helpers. 91.4 → 92.2 (+0.83%) Mgas/s
There was a problem hiding this comment.
Pull request overview
This PR optimizes BN254 pairing helper routines by reusing already-computed intermediate values to reduce redundant field arithmetic, improving precompile throughput.
Changes:
- Reuse
V = x0 * H_squaredwhen computingY3inlin_func_and_add(). - Avoid recomputing
z0 * z0_squaredfor line coefficients by usingz0_cubeddirectly.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+409
to
+410
| t[0] = z0_cubed * x0 - U2 * z0_cubed; | ||
| t[1] = S2 * z0_squared - y0 * z0_squared; |
Comment on lines
+435
to
+436
| t[0] = z0_cubed * x0 - U2 * z0_cubed; | ||
| t[1] = S2 * z0_squared - y0 * z0_squared; |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1542 +/- ##
=======================================
Coverage 96.97% 96.97%
=======================================
Files 163 163
Lines 14455 14455
Branches 3385 3385
=======================================
Hits 14018 14018
Misses 307 307
Partials 130 130
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reuses already computed terms in trivial cases in pairing helpers.
91.4 → 92.2 (+0.83%) Mgas/s