precompiles: Add Fq2 sqr() and use it in BN254 pairing helpers#1539
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR enhances BN254 pairing field arithmetic by introducing an optimized squaring implementation for Fq2 and teaching the generic extension-field multiplication operator to use sqr() when multiplying an element by itself. This fits into the precompiles pairing code by reducing the cost of common “square” operations that appear in pairing-related formulas.
Changes:
- Added
constexpr Fq2 sqr(const Fq2&)using a 2-multiplication squaring formula. - Updated
ecc::ExtFieldElem’soperator*to detecte * eand dispatch tosqr(e)when available via ADL.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
lib/evmone_precompiles/pairing/field_template.hpp |
Optimizes self-multiplication (a * a) by calling sqr(a) when a suitable overload exists. |
lib/evmone_precompiles/pairing/bn254/fields.hpp |
Adds Fq2 squaring helper to enable the generic self-multiply optimization and improve pairing arithmetic performance. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
Author
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1539 +/- ##
=======================================
Coverage 96.97% 96.97%
=======================================
Files 163 163
Lines 14450 14455 +5
Branches 3384 3385 +1
=======================================
+ Hits 14013 14018 +5
Misses 307 307
Partials 130 130
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
chfast
force-pushed
the
precompiles/bn254-fq2-sqr
branch
from
3d392a0 to
781dccc
Compare
Comment on lines
+74
to
+78
| if constexpr (requires { sqr(e1); }) // Use sqr() if available. | ||
| { | ||
| if (&e1 == &e2) | ||
| return sqr(e1); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.