blockservice: optimize getBlocks filter by not rescanning the already valid leading elements

[Jorropo]

We would scan the valid leading elements twice.

[Jorropo]

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

Current dependencies on/for this PR:

• main
  • PR blockservice: optimize getBlocks filter by not rescanning the already valid leading elements #558
    • PR blockservice: fix symbol name in docs #559
      • PR blockservice: stop using deprecated NewWriteThrough in tests #560
        • PR blockservice: remove deprecated NewWriteThrough function #565
        • PR blockservice: move session handling as part of the interface #563
          • PR blockservice: remove inner fields access methods #564
        • PR blockservice: move to single unique struct and add WithContentBlocker option #561
          • PR blockservice: remove inner fields access methods #562
            • PR Move providing responsabilities from bitswap to blockservice #534
              • PR Remove content routing from bitswap network #535
                • PR Remove provider query manager #536
        • PR blockservice: add WithContentBlocker option #556
          • PR blockservice: optimize getBlocks filter by not rescanning the already valid leading elements #557 👈

This stack of pull requests is managed by Graphite.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7e0cfb1) 65.56% compared to head (b2110e6) 65.54%.

@@                                 Coverage Diff                                  @@
##           01-15-blockservice_add_WithContentBlocker_option     #557      +/-   ##
====================================================================================
- Coverage                                             65.56%   65.54%   -0.02%     
====================================================================================
  Files                                                   204      207       +3     
  Lines                                                 25583    25654      +71     
====================================================================================
+ Hits                                                  16773    16815      +42     
- Misses                                                 7335     7361      +26     
- Partials                                               1475     1478       +3     

Files	Coverage Δ
blockservice/blockservice.go	80.12% <100.00%> (+0.30%)	⬆️

... and 15 files with indirect coverage changes

[Jorropo]

Closed in favor of #558