add configurable fallback timeout for the gateway handler #1079
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gammazero
commented
Dec 13, 2025
|
|
||
| // MaxRequestDuration per-request timeout for the gateway handler. It | ||
| // defaults to DefaultMaxRequestDuration. | ||
| MaxRequestDuration time.Duration |
Contributor
Author
There was a problem hiding this comment.
Does this need to be a duration string that can be parsed (e.g. "1h")?
Added a configurable fallback timeout for the gateway handler, defaulting to 1 hour. Configurable via `MaxRequestDuration` in the gateway config. Replaces #1069
gammazero
force-pushed
the
config-gw-request-timeout
branch
from
110dc2d to
8e2e90a
Compare
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## main #1079 +/- ##
=======================================
Coverage 61.09% 61.09%
=======================================
Files 264 264
Lines 26222 26226 +4
=======================================
+ Hits 16020 16023 +3
+ Misses 8524 8522 -2
- Partials 1678 1681 +3
... and 9 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a configurable fallback timeout for the gateway handler, defaulting to 1 hour. Configurable via
MaxRequestDurationin the gateway config.Replaces #1069