-
Notifications
You must be signed in to change notification settings - Fork 146
remove sha1 from list of hashes allowed in IPFS #1013
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
This will close kubo issue ipfs/kubo#8703 when the kubo PR with this update is merged.
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #1013 +/- ##
==========================================
+ Coverage 60.47% 60.50% +0.02%
==========================================
Files 267 267
Lines 33276 33277 +1
==========================================
+ Hits 20124 20133 +9
+ Misses 11485 11479 -6
+ Partials 1667 1665 -2
... and 9 files with indirect coverage changes 🚀 New features to boost your workflow:
|
|
Still needed for git compatibility.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SHA1 creates interesting question: what do we do with hash functions which are no longer considered secure, but there are DAGs created with it. i imagine we want to retain ability to read historical DAGS, but not create new ones?
It feels what we want here, is to have separate allowlist for reading (and sha1 would be allowed, due to historical use in Git DAGs), and separate for writing (we would refuse to create new dags with sha1).
right now boxo/verifcid has allowlist.IsAllowed which covers both.
does it make sense to add IsWriteAllowed and IsReadAllowed and switch to them in code so we allow reads of Sha1 but refuse writes? (keeping IsAllowed=IsWriteAllowed && IsReadAllowed for backward compatibility).
Closes kubo issue ipfs/kubo#8703