chore: Update libipld to 0.15 #40
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -18,7 +18,7 @@ async-trait = "0.1.52" | |
| fnv = "1.0.7" | ||
| futures = "0.3.19" | ||
| lazy_static = "1.4.0" | ||
| libipld = { version = "0.15.0", default-features = false } | ||
| libp2p = { version = "0.49.0", features = ["request-response"] } | ||
| prometheus = "0.13.0" | ||
| prost = { version = "0.9.0", optional = true } | ||
|
|
@@ -29,7 +29,7 @@ unsigned-varint = { version = "0.7.1", features = ["futures", "std"] } | |
| [dev-dependencies] | ||
| async-std = { version = "1.10.0", features = ["attributes"] } | ||
| env_logger = "0.9.0" | ||
| libipld = { version = "0.15.0", default-features = false, features = ["dag-cbor"] } | ||
| libp2p = { version = "0.49.0", features = ["tcp", "noise", "yamux", "rsa", "async-std"] } | ||
| multihash = { version = "0.17", default-features = false, features = ["blake3"] } | ||
|
Contributor
There was a problem hiding this comment. I’d prefer to stay in sync with libp2p on this one, which is still on 0.16.1.
Contributor
Author
There was a problem hiding this comment. Would have to double check, I believe this change was done for was due to the test using the reexport of
Contributor
There was a problem hiding this comment. just saw libp2p/rust-libp2p#3196, so we can do this now |
||
| tracing-subscriber = { version = "0.3.5", features = ["env-filter"] } | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will require many other crates to upgrade as well. Are there reasons to make this urgent? Otherwise I’d have postponed this to the next libp2p upgrade.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am using libipld 0.15 which applies this fix and because of using a newer version, libp2p-bitswap would give a compiler error due to the use of
StoreParamsfrom a newer version (which might fall back to a previous comment made in #39). If you wish to postpone, I can use a fork with this upgrade for the time being until it is updated hereThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right, those compilation errors are what then forces the upgrade dance on all my repos … we can merge this now but I’d like to hold back with releasing until libp2p 0.51 is out.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Waiting until libp2p 0.51 is fine with me.