Skip to content

Conversation

@zfergus
Copy link
Member

@zfergus zfergus commented Jul 21, 2025

Description

Replace smooth mu with a piecewise quadratic function

Type of change

  • Enhancement (non-breaking change which improves existing functionality)

@codecov
Copy link

codecov bot commented Jul 21, 2025

Codecov Report

Attention: Patch coverage is 80.95238% with 8 lines in your changes missing coverage. Please review.

Project coverage is 96.38%. Comparing base (f6ae3b7) to head (08c2574).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/ipc/friction/smooth_mu.cpp 78.26% 5 Missing ⚠️
src/ipc/adhesion/adhesion.cpp 84.21% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #179      +/-   ##
==========================================
- Coverage   96.47%   96.38%   -0.10%     
==========================================
  Files         103      103              
  Lines        7856     7878      +22     
==========================================
+ Hits         7579     7593      +14     
- Misses        277      285       +8     
Flag Coverage Δ
unittests 96.38% <80.95%> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@zfergus zfergus merged commit 801f82c into main Jul 21, 2025
32 checks passed
@zfergus zfergus deleted the quadratic-smooth-mu branch July 21, 2025 02:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants