Skip to content

Conversation

@zfergus
Copy link
Member

@zfergus zfergus commented May 2, 2025

Description

Add a index_t typedef for vertex/edge/face ids. Changes default from long to int32_t.

Type of change

  • Enhancement (non-breaking change which improves existing functionality)

Checklist

  • I have followed the project style guide
  • My code follows the clang-format style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@codecov
Copy link

codecov bot commented May 2, 2025

Codecov Report

Attention: Patch coverage is 96.49123% with 2 lines in your changes missing coverage. Please review.

Project coverage is 96.41%. Comparing base (63494e3) to head (c0e1cfb).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/ipc/collisions/normal/normal_collisions.cpp 66.66% 1 Missing ⚠️
src/ipc/collisions/normal/plane_vertex.hpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #161   +/-   ##
=======================================
  Coverage   96.41%   96.41%           
=======================================
  Files         102      102           
  Lines        7763     7765    +2     
=======================================
+ Hits         7485     7487    +2     
  Misses        278      278           
Flag Coverage Δ
unittests 96.41% <96.49%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@zfergus zfergus merged commit 28d515a into main May 2, 2025
32 checks passed
@zfergus zfergus deleted the index-typedef branch May 2, 2025 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants