Skip to content

Conversation

@zfergus
Copy link
Member

@zfergus zfergus commented Apr 29, 2025

Description

  • Refactor CMake configurations and improve project structure
  • Updated CMake recipes for third-party libraries to set appropriate folder properties for IDE organization.
  • Changed the CPMAddPackage references for scalable-ccd to a more recent commit.
  • Enhanced logging functionality by adding a new log_and_throw_error function to improve error handling.
  • Improved documentation in the style guide for naming conventions.
  • Move generated config.hpp file from src/ipc to build/include/src/ipc
  • Update CUDA builds in CMakePresets.json
  • Remove virtual tag from BroadPhase::detect_collision_candidates

Type of change

  • Enhancement (non-breaking change which improves existing functionality)

Checklist

  • I have followed the project style guide
  • My code follows the clang-format style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

- Updated CMake recipes for third-party libraries to set appropriate folder properties for IDE organization.
- Changed the CPMAddPackage references for scalable-ccd to a more recent commit.
- Enhanced logging functionality by adding a new `log_and_throw_error` function to improve error handling.
- Improved documentation in the style guide for naming conventions.
@zfergus zfergus requested a review from Copilot April 29, 2025 19:06

This comment was marked as duplicate.

@zfergus zfergus added this to the v1.4.0 milestone Apr 29, 2025
@zfergus zfergus added the enhancement New feature or request label Apr 29, 2025
@codecov
Copy link

codecov bot commented Apr 29, 2025

Codecov Report

Attention: Patch coverage is 25.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 96.43%. Comparing base (050aae8) to head (e89a8e4).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/ipc/utils/logger.cpp 0.00% 3 Missing ⚠️

❌ Your patch status has failed because the patch coverage (25.00%) is below the target coverage (75.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #159      +/-   ##
==========================================
- Coverage   96.46%   96.43%   -0.04%     
==========================================
  Files         102      102              
  Lines        7760     7763       +3     
==========================================
  Hits         7486     7486              
- Misses        274      277       +3     
Flag Coverage Δ
unittests 96.43% <25.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@zfergus zfergus merged commit ce35185 into main Apr 29, 2025
31 of 32 checks passed
@zfergus zfergus deleted the xcode branch April 29, 2025 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants