Skip to content

Conversation

@zfergus
Copy link
Member

@zfergus zfergus commented Feb 13, 2025

Description

This pull request focuses on removing the ContinuousCollisionCandidate class and its references, replacing it with the CollisionStencil class, and updating related documentation and bindings.

Type of change

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

Test Configuration:

  • OS and Version: macOS 15.3
  • Compiler and Version: Apple clang 16.0.0

Checklist

  • I have followed the project style guide
  • My code follows the clang-format style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@codecov
Copy link

codecov bot commented Feb 13, 2025

Codecov Report

Attention: Patch coverage is 69.23077% with 4 lines in your changes missing coverage. Please review.

Project coverage is 96.35%. Comparing base (44ad8a7) to head (f71a057).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/ipc/collisions/normal/plane_vertex.cpp 0.00% 4 Missing ⚠️

❌ Your patch status has failed because the patch coverage (69.23%) is below the target coverage (75.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #156      +/-   ##
==========================================
- Coverage   96.40%   96.35%   -0.06%     
==========================================
  Files         103      102       -1     
  Lines        7756     7758       +2     
==========================================
- Hits         7477     7475       -2     
- Misses        279      283       +4     
Flag Coverage Δ
unittests 96.35% <69.23%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zfergus zfergus merged commit 6676080 into main Feb 13, 2025
31 of 32 checks passed
@zfergus zfergus deleted the remove-ccd-candidate branch February 13, 2025 04:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants