Make raise_for_status configurable#159
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (4)
🚧 Files skipped from review as they are similar to previous changes (3)
Summary by CodeRabbit
WalkthroughAdds a Client constructor flag ChangesConditional Error Handling Feature
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Tip 💬 Introducing Slack Agent: The best way for teams to turn conversations into code.Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.
Built for teams:
One agent for your entire SDLC. Right inside Slack. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #159 +/- ##
===========================================
- Coverage 99.54% 87.78% -11.77%
===========================================
Files 18 18
Lines 440 442 +2
===========================================
- Hits 438 388 -50
- Misses 2 54 +52 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Defaults to the original behaviour of raising for status when making a request to the EPO OPS API
4b822aa to
46999b8
Compare
|
Awesome. I've done the rebase so history should be clean now. |
As noted in #36 the default behaviour of
response.raise_for_status()in_make_requestcollides with a possible413status code when the EPO OPS API considers the given input ambiguous.This PR will make this configurable by allowing to pass
raise_for_status=Falsewhen instantiating a client. The default behaviour has been left as-is, so anybody updating the library would not see a difference in behaviour.