Needed changes to use the latest record_tags.move version#228
Open
chrisgitiota wants to merge 2 commits intofeat/record-tagsfrom
Open
Needed changes to use the latest record_tags.move version#228chrisgitiota wants to merge 2 commits intofeat/record-tagsfrom
record_tags.move version#228chrisgitiota wants to merge 2 commits intofeat/record-tagsfrom
Conversation
chrisgitiota
changed the title
chrisgitiota
changed the title
record_tags.move version
itsyaasir
requested changes
Mar 21, 2026
|
|
||
| /// Returns if the specified is in use. | ||
| /// Returns false if the tag is not contained in the registry. | ||
| public(package) fun is_in_use(self: &TagRegistry, tag: &String): bool { |
Contributor
There was a problem hiding this comment.
is_in_use() is inverted here: it returns true when the usage count is 0, so remove_record_tag() now rejects unused tags and allows deleting tags that are still referenced by roles or records.`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR provides the needed changes to integrate the latest record_tags.move naming (PR #223) in the other AT Move modules.
The Move sources are compile-able, but some of the tests are failing.