Open
Conversation
…endency alignment
- Consolidate record tag management functions into a dedicated `tags` module. - Introduce `AddRecordTag`, `RemoveRecordTag`, and `SetRecordTags` transactions for better encapsulation. - Update permissions to include `AddRecordTags` and `DeleteRecordTags`. - Modify existing functions and tests to utilize the new structure for managing record tags. - Remove deprecated functions and ensure all references are updated accordingly. - Enhance tests to validate the new tag management functionality and permissions.
Contributor
Author
|
There are some important question remaining for this to be implemented fully.
|
| b"The requested tag is already defined for this audit trail"; | ||
| #[error] | ||
| const ERecordTagInUse: vector<u8> = | ||
| b"The requested tag cannot be removed because it is already used by an existing record"; |
Contributor
There was a problem hiding this comment.
Suggested change
| b"The requested tag cannot be removed because it is already used by an existing record"; | |
| b"The requested tag cannot be removed because it is already used by an existing record or role"; |
Several renamings and slightly changes in the record_tag related interfaces. Co-authored-by: Yasir <yasir@shariff.dev>
# Conflicts: # audit-trail-move/sources/audit_trail.move
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of change
Links to any relevant issues
Type of change
How the change has been tested
Change checklist