fix: DatasetList.get_ids() AttributeError when delayed=True#174
Open
Shreyaav18 wants to merge 3 commits intoioos:mainfrom
Open
fix: DatasetList.get_ids() AttributeError when delayed=True#174Shreyaav18 wants to merge 3 commits intoioos:mainfrom
Shreyaav18 wants to merge 3 commits intoioos:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #173
Two small changes to
DatasetListingliderpy/fetchers.py:self.dataset_ids = Nonein__init__for consistency withGliderDataFetcherget_ids()soself.dataset_idsis correctly assigned for bothdelayed=Trueanddelayed=FalseProblem
self.dataset_idswas only assigned inside theif not self.delayed:block. Whendelayed=True, this block was skipped but the method still attempted toreturn self.dataset_ids, which was never set, causing:Changes
__init__: Added explicit initialization:get_ids(): Moved assignment outside the conditional block.Testing
All 8 existing tests pass.
DatasetListcurrently has no test coverage.