feat(tabs): migrate to Modular Ionic#31116
Draft
thetaPC wants to merge 1 commit intoionic-modularfrom
Draft
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
thetaPC
commented
May 6, 2026
Comment on lines
-45
to
-46
| <button class="expand" onclick="updateBadgeCount()">Update Badge Count</button> | ||
| <button class="expand" onclick="updateBadgeColor()">Update Badge Color</button> |
Contributor
Author
There was a problem hiding this comment.
These buttons weren't doing anything. I do plan on adding updateBadgeCount to the tab-bar/test/badge page when we migrate.
thetaPC
commented
May 6, 2026
| </ion-header> | ||
| <ion-content class="ion-padding"> | ||
| Page Four | ||
| <h1>Page Four</h1> |
Contributor
Author
There was a problem hiding this comment.
Following the setup of the other 3 pages.
thetaPC
commented
May 6, 2026
| private setActive(selectedTab: HTMLIonTabElement): Promise<void> { | ||
| if (this.transitioning) { | ||
| return Promise.reject('transitioning already happening'); | ||
| return Promise.reject(new Error('transitioning already happening')); |
Contributor
Author
There was a problem hiding this comment.
This change attaches a stack trace to the rejection, making it easier to identify where the error originated when debugging.
thetaPC
commented
May 6, 2026
|
|
||
| if (!tabEl) { | ||
| printIonError(`[ion-tabs] - Tab with id: "${tabEl}" does not exist`); | ||
| printIonError(`[ion-tabs] - Tab with id: "${tab}" does not exist`); |
Contributor
Author
There was a problem hiding this comment.
This kept showing as [ion-tabs] - Tab with id: "undefined" does not exist so I fixed it by passing the correct variable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: resolves internal
What is the current behavior?
ion-tabsuses a legacy@importin its stylesheet, has a separatetabs-interface.tsfile (hyphen naming), and carries a@virtualProp themedoc that is no longer applicable after the Modular Ionic migration. An error message in thegetTabhelper always logs"undefined"instead of the actual tab id that was passed.What is the new behavior?
tabs-interface.ts->tabs.interfaces.tsto match the format in Modular Ionic@import "native.globals"to@use "../../themes/mixins" as mixins@virtualProp themeJSDocgetTab. Now correctly logs the tab id passed by the caller instead of always logging"undefined"Does this introduce a breaking change?
Other information
Previews