Skip to content

feat(list-header): add inner part #30930

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
brandyscarney wants to merge 2 commits into
base: feature-8.8
Choose a base branch
from
+38 −1
Open

feat(list-header): add inner part #30930

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f653e6b
feat(list-header): add inner part
brandyscarney Jan 19, 2026
e53dc7e
test(list-header): add e2e test for css shadow parts
brandyscarney Jan 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions core/api.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1018,6 +1018,7 @@ ion-list-header,css-prop,--color,ios
ion-list-header,css-prop,--color,md
ion-list-header,css-prop,--inner-border-width,ios
ion-list-header,css-prop,--inner-border-width,md
ion-list-header,part,inner

ion-loading,scoped
ion-loading,prop,animated,boolean,true,false,false
Expand Down
4 changes: 3 additions & 1 deletion core/src/components/list-header/list-header.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@ import type { Color } from '../../interface';

/**
* @virtualProp {"ios" | "md"} mode - The mode determines which platform styles to use.
*
* @part inner - The inner container element that wraps the list header content.
*/
@Component({
tag: 'ion-list-header',
Expand Down Expand Up @@ -40,7 +42,7 @@ export class ListHeader implements ComponentInterface {
[`list-header-lines-${lines}`]: lines !== undefined,
})}
>
<div class="list-header-inner">
<div class="list-header-inner" part="inner">
Copy link
Contributor

@thetaPC thetaPC Jan 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why would this be considered inner instead of content?

<slot></slot>
</div>
</Host>
Expand Down
34 changes: 34 additions & 0 deletions core/src/components/list-header/test/custom/list-header.e2e.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,34 @@
import { expect } from '@playwright/test';
import { configs, test } from '@utils/test/playwright';

/**
* This behavior does not vary across modes/directions
*/
configs({ directions: ['ltr'], modes: ['md'] }).forEach(({ title, config }) => {
test.describe(title('list-header: custom'), () => {
test.describe(title('CSS shadow parts'), () => {
test('should be able to customize inner part', async ({ page }) => {
await page.setContent(
`
<style>
ion-list-header::part(inner) {
background-color: red;
}
</style>

<ion-list-header>Header</ion-list-header>
`,
config
);

const header = page.locator('ion-list-header');
const backgroundColor = await header.evaluate((el) => {
const shadowRoot = el.shadowRoot;
const inner = shadowRoot?.querySelector('.list-header-inner');
return inner ? window.getComputedStyle(inner).backgroundColor : '';
});
expect(backgroundColor).toBe('rgb(255, 0, 0)');
});
});
});
});
Loading