Skip to content

feat(content): add content-fullscreen class when fullscreen is true #30926

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
brandyscarney wants to merge 2 commits into
base: feature-8.8
Choose a base branch
from
+29 −0
Open

feat(content): add content-fullscreen class when fullscreen is true #30926

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
238b58a
feat(content): add content-fullscreen class when fullscreen is applied
brandyscarney Jan 19, 2026
23f883a
test(content): add e2e test checking for content-fullscreen class
brandyscarney Jan 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions core/src/components/content/content.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -462,6 +462,7 @@ export class Content implements ComponentInterface {
role={isMainContent ? 'main' : undefined}
class={createColorClasses(this.color, {
[mode]: true,
'content-fullscreen': this.fullscreen,
'content-sizing': hostContext('ion-popover', this.el),
overscroll: forceOverscroll,
[`content-${rtl}`]: true,
Expand Down
28 changes: 28 additions & 0 deletions core/src/components/content/test/fullscreen/content.e2e.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,5 +13,33 @@ configs({ modes: ['md'], directions: ['ltr'] }).forEach(({ title, screenshot, co

await expect(page).toHaveScreenshot(screenshot(`content-fullscreen`));
});

test('should have content-fullscreen class when fullscreen is true', async ({ page }) => {
await page.setContent(
`
<ion-content fullscreen>
<p>Hello</p>
</ion-content>
`,
config
);

const content = page.locator('ion-content');
await expect(content).toHaveClass(/content-fullscreen/);
});

test('should not have content-fullscreen class when fullscreen is false', async ({ page }) => {
await page.setContent(
`
<ion-content>
<p>Hello</p>
</ion-content>
`,
config
);

const content = page.locator('ion-content');
await expect(content).not.toHaveClass(/content-fullscreen/);
});
});
});
Loading