fix(core): properly propagate rejections in addListenerNative#8405
Open
vamsi2246 wants to merge 1 commit intoionic-team:mainfrom
Open
fix(core): properly propagate rejections in addListenerNative#8405vamsi2246 wants to merge 1 commit intoionic-team:mainfrom
vamsi2246 wants to merge 1 commit intoionic-team:mainfrom
Conversation
Member
|
please, before you continue creating pull requests, create issues and provide reproductions |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently,
addListenerNativecreates a new promise that only handles the success case of the underlyingaddListenercall, causing it to hang on failure. This PR refactors it to use.then()on the original call, ensuring that rejections are correctly propagated. This also fixes an unhandled rejection.