Skip to content

fix(cli): properly copy all valid SSL certs and fix log typo #8404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vamsi2246 wants to merge 1 commit into
base: main
Choose a base branch
from
+2 −2
Open

fix(cli): properly copy all valid SSL certs and fix log typo #8404

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions cli/src/tasks/copy.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -254,13 +254,13 @@ async function copySSLCert(sslCertPaths: string[], rootDir: string, targetDir: s
`SSL Certificate does not exist at specified path.`,
);

return;
continue;
}
validCertPaths.push(certAbsFromPath);
}
const certsDirAbsToPath = join(targetDir, 'certs');
const certsDirRelToDir = relative(rootDir, targetDir);
await runTask(`Copying SSL Certificates from to ${certsDirRelToDir}`, async () => {
await runTask(`Copying SSL Certificates to ${certsDirRelToDir}`, async () => {
const promises: Promise<void>[] = [];
for (const certPath of validCertPaths) {
promises.push(fsCopy(certPath, join(certsDirAbsToPath, basename(certPath))));
Expand Down