fix(http): correctly serialize Blob objects in request bodies and FormData#8403
Open
vamsi2246 wants to merge 1 commit intoionic-team:mainfrom
Open
fix(http): correctly serialize Blob objects in request bodies and FormData#8403vamsi2246 wants to merge 1 commit intoionic-team:mainfrom
vamsi2246 wants to merge 1 commit intoionic-team:mainfrom
Conversation
Member
|
can you first create an issue with a sample app that reproduces this problem? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug Report / Context
When using
CapacitorHttpto intercept requests, dynamically generatedBlobobjects appended toFormDataor passed as the request body are silently corrupted. Because the native bridge only checksif (value instanceof File), genericBlobs fall through the type check and are improperly serialized as the literal string"[object Blob]".What This PR Does
Changes the strict
Fileinstance checks toBlobinnative-bridge.ts. Since allFileobjects are instances ofBlob, andFileReader.readAsBinaryString()natively accepts aBlob, this safely fixes the data corruption for both pureBlobs andFiles without introducing any breaking changes.instanceof Filewithinstanceof BlobinconvertFormDataandconvertBody.readFileAsBase64signature to acceptBlob.fileNamefor generic Blobs that do not inherently have a.nameproperty.