feat: Google Maps npm library updates #151
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+125
to
+131
| lib.setOptions({ | ||
| key: apiKey ?? '', | ||
| language, | ||
| region, | ||
| }); | ||
| this.gMapsRef = await loader.importLibrary('maps'); | ||
|
|
||
| this.gMapsRef = await lib.importLibrary('maps'); |
Contributor
There was a problem hiding this comment.
Note: Looks like this ends up addressing #147 (for which there was an alternative PR, that I guess becomes obsolete if this gets merged).
The PR title may need a rename because of this - explicitly mention updates to google maps, mention refactor of loader? Idk, I'll leave it to you @theproducer heh
theproducer
changed the title
OS-pedrogustavobilro
approved these changes
Dec 2, 2025
alexgerardojacinto
approved these changes
Dec 2, 2025
WallsStarring
pushed a commit
to WallsStarring/capacitor-google-maps
that referenced
this pull request
Dec 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.