Skip to content

feat: Use functional API of @googlemaps/js-api-loader #148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AE1NS wants to merge 3 commits into
base: main
Choose a base branch
from
Open

feat: Use functional API of @googlemaps/js-api-loader #148

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7dbd527
feat: Use functional API of @googlemaps/js-api-loader
A1Jan Nov 18, 2025
b5adcea
Merge remote-tracking branch 'upstream/main' into api-loader-refactoring
theproducer Dec 3, 2025
2859f13
fmt
theproducer Dec 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 5 additions & 7 deletions plugin/src/web.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ import type {
RemovePolylinesArgs,
RemoveTileOverlayArgs,
} from './implementation';
import { importLibrary, setOptions } from '@googlemaps/js-api-loader';

export class CapacitorGoogleMapsWeb extends WebPlugin implements CapacitorGoogleMapsPlugin {
private gMapsRef: google.maps.MapsLibrary | undefined = undefined;
Expand Down Expand Up @@ -121,19 +122,16 @@ export class CapacitorGoogleMapsWeb extends WebPlugin implements CapacitorGoogle

private async importGoogleLib(apiKey: string, region?: string, language?: string) {
if (this.gMapsRef === undefined) {
const lib = await import('@googlemaps/js-api-loader');
lib.setOptions({
setOptions({
key: apiKey ?? '',
v: 'weekly',
language,
region,
});

this.gMapsRef = await lib.importLibrary('maps');
this.gMapsRef = await importLibrary('maps');

// Import marker library once
const { AdvancedMarkerElement, PinElement } = (await google.maps.importLibrary(
'marker',
)) as google.maps.MarkerLibrary;
const { AdvancedMarkerElement, PinElement } = await importLibrary('marker');
this.AdvancedMarkerElement = AdvancedMarkerElement;
this.PinElement = PinElement;

Expand Down