Skip to content

Conversation

@OS-pedrogustavobilro
Copy link
Contributor

To address #40

@alextreppass / @kzKallisti / @HarelM feel free to leave feedback!

@OS-pedrogustavobilro OS-pedrogustavobilro requested a review from a team January 23, 2026 17:10
@HarelM
Copy link

HarelM commented Jan 23, 2026

This looks good, thanks! I would consider addind a base64 encoding option to explicitly say "hey I'm passing a base64 string", right now you have to pass "undefined" (or omit encoding) if you pass a base64 string. You might consider also adding something like:
If the provided content is not a base64 string this will throw an error, although this might be implied anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants