Fix doctests #79
Closed
Fix doctests #79
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The doctests weren't being run and had bitrotted. Make them work again.
macos-latest doesn't seem to have working binaries for these.
Contributor
This fixes `CoverageWarning: Couldn't parse Python file '.../tests/badsyntax.py' (couldnt-parse)`. Based on a change by Oldřich Jedlička.
Contributor
Author
|
@oldium Thanks for the suggestion! I think that change is very slightly too broad: coverage data for tests is good (because it makes it harder to have test code that's accidentally never executed, e.g. due to two test cases having the same function names), but of course it doesn't make sense to run coverage on some of these examples. I made a similar commit 4756288, which just omits |
Owner
|
Included in #82. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The doctests weren't being run and had bitrotted. Make them work again.