This repository was archived by the owner on May 19, 2021. It is now read-only.
ACL merge double work #202
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The feature acl branch removes all user bases permissions. This page is not longer needed.
Lyra2108
approved these changes
Sep 9, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems like I did some work twice – with some months as gap between it. (compare https://github.com/inyokaproject/theme-default/compare/feature/acl with #187)
I now extracted all changes from
feature/aclwhich are still relevent. After a merge, ACL should be fully migrated into the existing templates of theme-default. So, after this one is merged the branchfeature/aclcan be deleted…