Skip to content

chore: skill with validation commands for TS/JS development#9012

Open
russellwheatley wants to merge 2 commits intomainfrom
initial-skill
Open

chore: skill with validation commands for TS/JS development#9012
russellwheatley wants to merge 2 commits intomainfrom
initial-skill

Conversation

@russellwheatley
Copy link
Copy Markdown
Member

@russellwheatley russellwheatley commented May 8, 2026

Description

  • Adds a ts-js-validation skill for validating RNFB TypeScript and JavaScript changes.
  • Runs the standard root workflow: lerna:prepare, both TypeScript compile checks, Jest, then JS/TS formatting.
  • Documents failure handling, rerun expectations, and concise reporting for validation results.
  • Keeps the workflow scoped to JS/TS changes, excluding native/platform and full release validation.

Related issues

Release Summary

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
    • Yes
  • My change supports the following platforms;
    • Android
    • iOS
    • Other (macOS, web)
  • My change includes tests;
    • e2e tests added or updated in packages/\*\*/e2e
    • jest tests added or updated in packages/\*\*/__tests__
  • I have updated TypeScript types that are affected by my change.
  • This is a breaking change;
    • Yes
    • No

Test Plan


Think react-native-firebase is great? Please consider supporting the project with any of the below:

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a new skill definition for automated TypeScript and JavaScript validation. The goal is to provide a standardized workflow for developers to verify their changes before committing, ensuring consistency across the monorepo by running essential build, test, and formatting scripts.

Highlights

  • New Skill Definition: Added a new agent skill configuration file for TS/JS validation within the React Native Firebase monorepo.
  • Validation Workflow: Defined a structured validation sequence including lerna preparation, TypeScript compilation, Jest testing, and code formatting.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new agent skill, ts-js-validation, designed to automate the validation of TypeScript and JavaScript changes within the React Native Firebase monorepo. The feedback focuses on improving the efficiency and thoroughness of the validation process by recommending that yarn format:js be executed at the beginning of the sequence and that yarn lint:js be included as a standard step. These changes ensure that all subsequent checks, such as linting, compilation, and testing, are performed on the final formatted code.

Comment thread .agents/skills/ts-js-validation/SKILL.md
Comment thread .agents/skills/ts-js-validation/SKILL.md
Comment thread .agents/skills/ts-js-validation/SKILL.md
Comment thread .agents/skills/ts-js-validation/SKILL.md
Comment thread .agents/skills/ts-js-validation/SKILL.md
Comment thread .agents/skills/ts-js-validation/SKILL.md
Copy link
Copy Markdown
Collaborator

@mikehardy mikehardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

99% +1 (structure, motivation all of that) - reserving 1% for idea maybe yarn reference:api and yarn compare:types could be included

approving as works either way - at your discretion

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants