chore: skill with validation commands for TS/JS development#9012
chore: skill with validation commands for TS/JS development#9012russellwheatley wants to merge 2 commits intomainfrom
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a new skill definition for automated TypeScript and JavaScript validation. The goal is to provide a standardized workflow for developers to verify their changes before committing, ensuring consistency across the monorepo by running essential build, test, and formatting scripts. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces a new agent skill, ts-js-validation, designed to automate the validation of TypeScript and JavaScript changes within the React Native Firebase monorepo. The feedback focuses on improving the efficiency and thoroughness of the validation process by recommending that yarn format:js be executed at the beginning of the sequence and that yarn lint:js be included as a standard step. These changes ensure that all subsequent checks, such as linting, compilation, and testing, are performed on the final formatted code.
mikehardy
left a comment
There was a problem hiding this comment.
99% +1 (structure, motivation all of that) - reserving 1% for idea maybe yarn reference:api and yarn compare:types could be included
approving as works either way - at your discretion
Description
Related issues
Release Summary
Checklist
AndroidiOSOther(macOS, web)e2etests added or updated inpackages/\*\*/e2ejesttests added or updated inpackages/\*\*/__tests__Test Plan
Think
react-native-firebaseis great? Please consider supporting the project with any of the below:React Native FirebaseandInvertaseon Twitter