refactor(installations)!: migrate to TypeScript#9002
refactor(installations)!: migrate to TypeScript#9002russellwheatley wants to merge 9 commits intomainfrom
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request completes the migration of the installations package to TypeScript. It updates the build configuration to use modern standards, improves type definitions, and refactors the internal module structure to align with the project's modular API strategy while ensuring existing consumers remain supported. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request transitions the Firebase Installations package to a modular architecture, adding modular API functions and updating the build process with react-native-builder-bob. It also includes comprehensive type definitions and consistency check configurations. Feedback focuses on simplifying the implementation of getInstallations and getToken by utilizing optional chaining and boolean conversion to eliminate redundant conditional logic.
Updated to main and re-pushed to verify things still work since we're not using a merge queue here
release notes will come from the commit, so here's the draft of the commit message pulled from the description:
BREAKING CHANGE: installations modular types now match firebase-js-sdk
Please see https://rnfirebase.io/migrating-to-v25 for help migrating if needed.
react-native-firebase has a goal to be a drop-in replacement for firebase-js-sdk, with native extensions and performance. It has always worked that way at the javascript level but the typescript types have been divergent.
We are fixing that as we refactor to typescript. Please bear with us as we get closer to our goal of react-native-firebase matching firebase-js-sdk both in functionality where possible, but also in exact typescript typing.
Specifics for Installations:
getInstallations()to return the firebase-js-sdk-styleInstallationstype, which only exposesapp; TypeScript consumers should use the modular helpersgetId(installations),getToken(installations), anddeleteInstallations(installations)instead of calling.getId(),.getToken(), or.delete()on the returned instance.deleteInstallations(installations)so theinstallationsargument is required in the TypeScript surface, matching firebase-js-sdk. Code that previously relied on the old optional typing should passgetInstallations()explicitly.installations(),firebase.installations(),firebase.app().installations(), andFirebaseInstallationsTypes.Moduleremain available for compatibility, with deprecation annotations added.Installations,IdChangeCallbackFn, andIdChangeUnsubscribeFn.Related issues
Release Summary
Checklist
AndroidiOSOther(macOS, web)e2etests added or updated inpackages/\*\*/e2ejesttests added or updated inpackages/\*\*/__tests__Test Plan
Think
react-native-firebaseis great? Please consider supporting the project with any of the below:React Native FirebaseandInvertaseon Twitter