WIP fix(app, ios): generate app package module map for swift interop#8925
Draft
WIP fix(app, ios): generate app package module map for swift interop#8925
Conversation
this should resolve an issue seen with my expo demo script where static linking wasn't working correctly via per-module directives in combination with the new prebuilt (non-static...) react-native core
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
this should resolve an issue seen with my expo demo script where static linking wasn't working correctly via per-module directives in combination with the new prebuilt (non-static...) react-native core
Related issues
Nothing logged - this was seen with my Expo demo script which has these currently unique features, from the perspective of how we test:
When you do this, and you do not have this fix, you see:
With this, it builds farther but still fails later which is why this is still
WIP:Specifically this import isn't found:
Note that this is not needed on current release v23.8.6, I only see this failure on main, so it isn't breaking for people...yet
Additionally, if you opt out of the prebuilt react-native core you won't see it, but everyone wants to use that and the issues in this repo about it are very active.
Release Summary
Checklist
AndroidiOSOther(macOS, web)e2etests added or updated inpackages/\*\*/e2ejesttests added or updated inpackages/\*\*/__tests__Test Plan
.github/workflows/scripts/create_npm_packages.sh packages ~/packagesYou'll see the compile error I mention until you add this module map compile flag, then you'll see the swift bridging header import issue until I figure that out...
Think
react-native-firebaseis great? Please consider supporting the project with any of the below:React Native FirebaseandInvertaseon Twitter