Skip to content

docs: remove no-longer-present signatures graphql#8916

Open
mikehardy wants to merge 1 commit intomainfrom
@mikehardy/fix-old-website-graphql
Open

docs: remove no-longer-present signatures graphql#8916
mikehardy wants to merge 1 commit intomainfrom
@mikehardy/fix-old-website-graphql

Conversation

@mikehardy
Copy link
Collaborator

Description

after merge of firestore conversion it appears there are no more typescript types that have the signatures block for use in the old graphql used to build reference docs via gatsby

remove the block and the website builds again

Related issues

Release Summary

shouldn't trigger a release but looking at the generated reference docs on the PR build in vercel will be instructive

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
    • Yes
  • My change supports the following platforms;
    • Android
    • iOS
    • Other (macOS, web)
  • My change includes tests;
    • e2e tests added or updated in packages/\*\*/e2e
    • jest tests added or updated in packages/\*\*/__tests__
  • I have updated TypeScript types that are affected by my change.
  • This is a breaking change;
    • Yes
    • No

Test Plan

Check the Vercel deployment to see if it still looks "okay", where "okay" is not that great since the old reference site generator finds the new typescript modules impenetrable, c.f.:


Think react-native-firebase is great? Please consider supporting the project with any of the below:

after merge of firestore conversion it appears there are no more
typescript types that have the signatures block for use in the old
graphql used to build reference docs via gatsby

remove the block and the website builds again
@vercel
Copy link

vercel bot commented Mar 5, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
react-native-firebase Ready Ready Preview, Comment Mar 5, 2026 4:39pm

Request Review

@mikehardy
Copy link
Collaborator Author

Well, as expected firestore docs are now missing which is kind of a big deal, but the reference API in general is still built now, and Vercel no longer errors:

https://react-native-firebase-git-mikehardy-fix-old-we-c6f5f6-invertase.vercel.app/reference

@mikehardy
Copy link
Collaborator Author

One thought - if I merge this firestore docs will be rebuilt live from main and they will then disappear - currently because main hasn't build successfully firestore reference docs are still there 😅

Going to hold off for a moment until I can think of a better reference API website solution (still thinking github pages built directly from typedoc and then pointed to from vercel and/or docs.page at this point, since docs.page munges up the output)

@mikehardy mikehardy added the blocked: do-not-merge Do not merge this issue without approval by the person who labelled this issue as Do Not Merge label Mar 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

blocked: do-not-merge Do not merge this issue without approval by the person who labelled this issue as Do Not Merge Workflow: Pending Merge Waiting on CI or similar

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant