refactor(database)!: move to typescript #8915
Draft
MichaelVerdon wants to merge 2 commits intomainfrom
Draft
Conversation
…ation - Add lib/types/database.ts with public/modular types (Database, Statics, Reference, Query, etc.) - Add lib/types/namespaced.ts with deprecated FirebaseDatabaseTypes namespace - Add lib/types/internal.ts with DatabaseInternal and WithModularDeprecationArg - Move FirebaseDatabaseModule and createModuleNamespace into lib/namespaced.js - Slim lib/index.js to re-export from namespaced and modular - Replace lib/index.d.ts with barrel re-exporting types and declare module augmentation - Include database type sources in root tsconfig
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
…cation tests - Use Database and Reference from types/database in modular declarations - Export Statics from modular; fix getServerTime return type to Date - Trim tsconfig to type-test only for database package - Add @ts-expect-error for namespaced API usage in V9 deprecation tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ation
Description
Related issues
Release Summary
Checklist
AndroidiOSOther(macOS, web)e2etests added or updated inpackages/\*\*/e2ejesttests added or updated inpackages/\*\*/__tests__Test Plan
Think
react-native-firebaseis great? Please consider supporting the project with any of the below:React Native FirebaseandInvertaseon Twitter