Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
First TypeScript migration for the perf package. Source is now written in TypeScript and namespaced types are fully separated from modular types:
lib/types/namespaced.tsand are aligned with the previous index.d.ts surface. This keeps the migration low-risk and makes it straightforward to remove namespaced support later.lib/types/modular.tsand are consumed only by the modular API; the same file also contains the modular implementation (getPerformance, initializePerformance, trace, httpMetric, newScreenTrace, startScreenTrace).lib/types/internal.tsdefinesPerformanceModuleWithModularArgfor internal modular-call typing.Breaking Changes
No consumer-facing breaking changes. Same public API and type surface; only the implementation and type file layout have changed (JS → TS, types split into types/namespaced.ts and types/modular.ts).
Related issues
Release Summary
@react-native-firebase/perf: TypeScript migration; namespaced and modular types separated into types/namespaced.ts and types/modular.ts. No API changes.
Checklist
packages/**/e2e(existing e2e unchanged; type-test and build validate TS)packages/**/__tests__(existing tests updated for TS where applicable)Test Plan
yarn compileat repo root (builds all packages including perf).packages/perf/type-test.tsis included in root tsc and passes.packages/perf/e2e/perf.e2e.js.packages/perf/__tests__/.Think react-native-firebase is great? Please consider supporting the project with any of the below: