refactor(app-check)!: match AppCheck type with firebase-js-sdk#8889
Open
russellwheatley wants to merge 20 commits intomainfrom
Open
refactor(app-check)!: match AppCheck type with firebase-js-sdk#8889russellwheatley wants to merge 20 commits intomainfrom
russellwheatley wants to merge 20 commits intomainfrom
Conversation
…AR_DEPRECATION_ARG
…pcheck.ts type so modular only
…s another change needed
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
mikehardy
requested changes
Feb 19, 2026
Collaborator
mikehardy
left a comment
There was a problem hiding this comment.
Code looks good - but the docs (migrating to v24 + AppCheck docs with our custom provider config info example etc) definitely need an update for this one or the support load in the area will stay high vs immediately going to zero
|
Hello 👋, this PR has been opened for more than 14 days with no activity on it. If you think this is a mistake please comment and ping a maintainer to get this merged ASAP! Thanks for contributing! You have 7 days until this gets closed automatically |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Updates to match firebase-js-sdk:
AppChecknow matches firebase-js-sdk (no instance methods); use modular functions likeinitializeAppCheck,getToken,getLimitedUseToken,setTokenAutoRefreshEnabled,onTokenChangedinstead, matching firebase-js-sdk. See commit 423b3e915.onTokenChangedcallback result type changed fromAppCheckListenerResulttoAppCheckTokenResult. See commit 86982934a.FirebaseAppis no longer exported from@react-native-firebase/app-check; importFirebaseAppfrom@react-native-firebase/app. See commit 423b3e915.AppCheckStatics), aligning closer to firebase-js-sdk. See commit f5de6b89b.FirebaseAppCheckTypesis now a type-only export (no runtime export); update any value imports toimport type. See commit 540ee789f.lib/providers.ts(exports updated). See commit 76ab3a848.Related issues
Release Summary
Checklist
AndroidiOSOther(macOS, web)e2etests added or updated inpackages/\*\*/e2ejesttests added or updated inpackages/\*\*/__tests__Test Plan
Think
react-native-firebaseis great? Please consider supporting the project with any of the below:React Native FirebaseandInvertaseon Twitter