refactor(app-dist)!: migrate to TypeScript#8860
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
russellwheatley
left a comment
There was a problem hiding this comment.
Looking good so far, @MichaelVerdon 👍
|
Hello 👋, this PR has been opened for more than 14 days with no activity on it. If you think this is a mistake please comment and ping a maintainer to get this merged ASAP! Thanks for contributing! You have 7 days until this gets closed automatically |
russellwheatley
left a comment
There was a problem hiding this comment.
Also need to reinstate index.d.ts and call it namespaced.ts. Namespaced should use namespaced types. Also need to deprecate all api on it. See storage types/namespaced.ts: https://github.com/invertase/react-native-firebase/pull/8824/changes#diff-fd5d9fcbc03d8f4891bacac55f4e1f793eb5c1c95a5acdb6ad85f1bbd14ee205R15-R1248
Description
Related issues
Release Summary
Checklist
AndroidiOSOther(macOS, web)e2etests added or updated inpackages/\*\*/e2ejesttests added or updated inpackages/\*\*/__tests__Test Plan
Think
react-native-firebaseis great? Please consider supporting the project with any of the below:React Native FirebaseandInvertaseon Twitter