sort domain objects by class name #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wied03
requested changes
Apr 21, 2025
|
|
||
| if (settings.domainDirectory.toFile().exists()) { | ||
| settings.domainDirectory.eachFile(FileType.FILES) { f -> | ||
| def domainFiles = [] |
Contributor
There was a problem hiding this comment.
since we may have to live w/ this library for a little bit longer, can we replicate the problem with the tests this project has, to go with the fix?
Contributor
Author
There was a problem hiding this comment.
I was afraid someone would ask for that. But yeah, it should be tested.
Contributor
wied03
approved these changes
Apr 22, 2025
This was referenced Apr 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
Problem:
Every time we touch domain objects, the go and typescript clients get generated in a different order. This makes it impossible to determine what changed in client PRs. Furthermore, the order for a pegged version can vary from one developer to another.
This is a result of the domain objects getting loaded in from directory lists. The client generating freemarker then uses code like
[#list domain as d]to iterate over them.Solution:
Sort the domain objects by their "class" name (the last real name in a file like
io.fusionauth.domain.Tenant.jsonLinked PR:
I believe the openapi file issue was resolved in the linked Linear issue.
Reviewer Notes:
I tested this locally with an integration build by stepping through
fusionauth-appcommits making domain changes.