Conversation
…x error handling by using wrapper for directory chain creation everywhere
isc-dchui
requested review from
isc-cborbonm,
isc-egabhart,
isc-eneil,
isc-jili,
isc-jlechtne,
isc-kiyer,
isc-pbarton and
isc-tleavitt
as code owners
isc-tleavitt
approved these changes
May 12, 2026
isc-kiyer
requested changes
May 12, 2026
Collaborator
isc-kiyer
left a comment
isc-kiyer
left a comment
There was a problem hiding this comment.
@isc-dchui few small notes. Probably worth waiting until #1149 is merged before merging this one in
| @@ -156,7 +156,7 @@ ClassMethod CreateDirectoryChain(pName As %String) As %Status | |||
| { | |||
| set tSC = $$$OK | |||
| if '##class(%Library.File).CreateDirectoryChain(pName,.tReturn) { | |||
Collaborator
There was a problem hiding this comment.
Should this also be updated to use %IPM.Util.File:CreateDirectoryChain()?
| // where the developer works on files in-place. | ||
| if '$get(tParams("DeveloperMode"), 0) { | ||
| set tModuleObj = ##class(%IPM.Utils.Module).GetModuleObjectFromPath(tTargetDirectory, .tFound) | ||
| set tFinalDirectory = ##class(%Library.File).NormalizeDirectory( |
Collaborator
There was a problem hiding this comment.
This should use ModuleRoot once the other PR is merged in
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
loadwill also unpack tarballs/copy non-tarball sources to the${ipmdir}directory thatinstallusesTesting
Added new test to Test.PM.Integration.FileBinaryTar
Tested the error handling wrapper and got this very readable error:
Checklist
mainbranch rebased or merged.zpm test -only) and integration tests (zpm verify -only) pass.