Skip to content

[CORE-8091] restored btn size #2590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
trtshen merged 3 commits into from
Nov 21, 2025
Merged

[CORE-8091] restored btn size #2590

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4aa8ece
Merge pull request #2586 from intersective/2.4.y.z/CORE-8090/password…
trtshen Nov 20, 2025
0a89af1
[CORE-8091] restore button size for WCAG compliance
trtshen Nov 21, 2025
1d339f6
Merge remote-tracking branch 'origin/2.4.y/CORE-8091/restore-btn-size…
trtshen Nov 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 24 additions & 3 deletions projects/v3/src/app/components/bottom-action-bar/bottom-action-bar.component.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,30 @@
color: var(--ion-color-dark);
padding: 8px 0;

ion-button.ion-focused {
border: 1px solid black;
border-radius: 8px;
ion-button {
min-width: 200px;
flex: 0 1 auto;

// restore padding that was removed by global button reset
--padding-top: 13px;
--padding-bottom: 13px;
min-height: 44px; // WCAG 2.5.8 target size minimum

&.ion-focused {
border: 1px solid black;
border-radius: 8px;
}

// target shadow DOM button to restore padding
&::part(native) {
padding-top: 13px;
padding-bottom: 13px;
}

// ensure proper sizing on desktop
@media (min-width: 768px) {
min-width: 240px;
}
}
}

Expand Down
6 changes: 3 additions & 3 deletions projects/v3/src/global.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,12 +84,12 @@ ion-item-divider {
// Use darker background for WCAG contrast compliance (4.5:1 for normal text)
// color-mix creates darker shade: 60% primary + 40% dark green
background-color: color-mix(in srgb, var(--ion-color-primary) 60%, #1a4d2a);

// Fallback for browsers without color-mix support
@supports not (color-mix(in srgb, white, black)) {
background-color: var(--ion-color-primary-shade, #2a6d3f);
}

color: white;
text-decoration: none;
z-index: 9999;
Expand Down Expand Up @@ -173,7 +173,7 @@ p, span, div, ion-label, ion-text {
.icon-button {
background: none;
border: none;
padding: 0;
padding: 0; // WCAG 2.5.8 target size compliance
cursor: pointer;
display: inline-flex;
align-items: center;
Expand Down