[PB-6386] Fix display name#241
Conversation
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
meet-web | 2faf66d | Commit Preview URL Branch Preview URL |
May 22 2026, 02:35 PM |
There was a problem hiding this comment.
I would recommend you to use When..., then... to describe the tests and avoiding using technical words so if a variable changes, you don't need to change the test description. It would be better if you describes the functionality rather than the expected behavior of a variable/function. You know what I mean?
E.g. test('Wen calling the storage multiple times, then the same storage is returned always'... ), test('When there is no name, then nothing is stored', ...)
There was a problem hiding this comment.
Use test instead of it. it is for should... and test to describe when..., then...
| deploy-appbundle: | ||
| cp $(BUILD_DIR)/*.min.js $(DEPLOY_DIR) | ||
| -cp $(BUILD_DIR)/*.min.js.map $(DEPLOY_DIR) | ||
| @if [ -d "$(BUILD_DIR)/chunks" ]; then \ |
There was a problem hiding this comment.
Because in prod, we (Jitsi) build in chunks for performance. Now in prod, there are a bunch of errors because of chunks not being found (because the chunks folder is not copied). All works, because it falls back to serving the entier file I think, but still complains a lot:
|
Deploying meet-web with
|
| Latest commit: | 2faf66d |
| Status: | ✅ Deploy successful! |
| Preview URL: | https://765c9192.meet-web.pages.dev |
| Updated (Europe/Madrid): | 22/5/2026, 16:34:50 |
2 participants
Description
This PR fixes a bug that caused the drive user's temporary name change. Also, it fixes the name reset on reload. Now the display name is kept as long as local storage is not cleaned.
Also, it updates the icon to the new style (+ removes the unused icon), fixes chunk serving error in logs on the prod, and 404 error for apple-touch icon.
Related Issues
PB-6386
Related Pull Requests
Kick out PR
Checklist
How Has This Been Tested?
Local QA
Additional Notes
I couldn't find any proper icon. I guess once we do the app, we'll think of it. This is just to make sure that when Chrome proposes to install Meet as an app, the icon is somewhat new.