[PB-6385] Fix duplicated user kick out

src/modules/call/call.controller.spec.ts

@@ -316,11 +316,10 @@ describe('Testing Call Endpoints', () => {
   describe('Leaving a call', () => {
     it('When leaving a call for authenticated user, then it should leave successfully', async () => {
       callUseCase.leaveCall.mockResolvedValue();
+      const leaveCallDto = new LeaveCallDto();
+      leaveCallDto.userId = mockUserPayload.uuid;
 
-      const result = await callController.leaveCall(
-        mockRoomId,
-        mockUserPayload,
-      );
+      const result = await callController.leaveCall(mockRoomId, leaveCallDto);
 
       expect(result).toBeUndefined();
       expect(callUseCase.leaveCall).toHaveBeenCalledWith(
@@ -336,7 +335,7 @@ describe('Testing Call Endpoints', () => {
 
       callUseCase.leaveCall.mockResolvedValue();
 
-      await callController.leaveCall(mockRoomId, null, leaveCallDto);
+      await callController.leaveCall(mockRoomId, leaveCallDto);
 
       expect(callUseCase.leaveCall).toHaveBeenCalledWith(
         mockRoomId,
@@ -350,37 +349,34 @@ describe('Testing Call Endpoints', () => {
 
       callUseCase.leaveCall.mockResolvedValue();
 
-      const userToken = createMockUserToken();
-      await callController.leaveCall(
-        mockRoomId,
-        userToken.payload,
-        leaveCallDto,
-      );
+      await callController.leaveCall(mockRoomId, leaveCallDto);
 
       expect(callUseCase.leaveCall).toHaveBeenCalledWith(
         mockRoomId,
-        userToken.payload.uuid,
+        'anonymous-user-id',
       );
     });
 
     it('When neither authenticated user nor DTO with userId are provided, then it should pass undefined', async () => {
       const emptyDto = new LeaveCallDto();
       callUseCase.leaveCall.mockResolvedValue();
 
-      await callController.leaveCall(mockRoomId, null, emptyDto);
-
-      expect(callUseCase.leaveCall).toHaveBeenCalledWith(mockRoomId, undefined);
+      await expect(
+        callController.leaveCall(mockRoomId, emptyDto),
+      ).rejects.toThrow(BadRequestException);
     });
 
     it('When room is not found, then it should propagate NotFoundException', async () => {
-      const userToken = createMockUserToken();
+      const anonymousUserId = 'anonymous-user-id';
+      const leaveCallDto = new LeaveCallDto();
+      leaveCallDto.userId = anonymousUserId;
 
       callUseCase.leaveCall.mockRejectedValue(
         new NotFoundException('Specified room not found'),
       );
 
       await expect(
-        callController.leaveCall(mockRoomId, userToken.payload),
+        callController.leaveCall(mockRoomId, leaveCallDto),
       ).rejects.toThrow(NotFoundException);
     });
 

src/modules/call/call.controller.ts

@@ -173,12 +173,14 @@ export class CallController {
   })
   @ApiNotFoundResponse({ description: 'Call/Room not found' })
   @ApiInternalServerErrorResponse({ description: 'Internal server error' })
-  leaveCall(
+  async leaveCall(
     @Param('id') roomId: string,
-    @User() user: UserTokenData['payload'],
     @Body() leaveCallDto?: LeaveCallDto,
   ): Promise<void> {
-    const { uuid } = user || {};
-    return this.callUseCase.leaveCall(roomId, uuid || leaveCallDto?.userId);
+    if (!leaveCallDto?.userId) {
+      this.logger.warn('Attempt to leave call without user ID:', leaveCallDto);
+      throw new BadRequestException('The user id is needed to leave the call');
+    }
+    return this.callUseCase.leaveCall(roomId, leaveCallDto.userId);
   }
 }

src/modules/call/call.usecase.spec.ts

@@ -246,7 +246,7 @@ describe('CallUseCase', () => {
       expect(result).toEqual({
         token: 'test-jwt-token',
         room: roomId,
-        userId,
+        userId: autoGeneratedUUID,
         appId: 'jitsi-app-id',
       });
     });
@@ -418,7 +418,7 @@ describe('CallUseCase', () => {
       expect(result).toEqual({
         token: 'test-jwt-token',
         room: roomId,
-        userId,
+        userId: autoGeneratedUUID,
         appId: 'jitsi-app-id',
       });
     });
@@ -490,7 +490,7 @@ describe('CallUseCase', () => {
           anonymous: false,
         },
       );
-      expect(result.userId).toEqual(roomUserMock.userId);
+      expect(result.userId).toEqual(roomUserMock.id);
     });
   });
 

src/modules/call/call.usecase.ts

@@ -182,7 +182,7 @@ export class CallUseCase {
     return {
       token: callTokenData,
       room: roomId,
-      userId: roomUser.userId,
+      userId: roomUser.id,
       appId: this.configService.get<string>('jitsi.appId'),
     };
   }

src/modules/call/infrastructure/room-user.repository.spec.ts

@@ -225,7 +225,7 @@ describe('SequelizeRoomUserRepository', () => {
 
       expect(deleteRoomUserSpy).toHaveBeenCalledWith({
         where: {
-          userId: 'test-user-id',
+          id: 'test-user-id',
           roomId: 'test-room-id',
         },
       });

src/modules/call/infrastructure/room-user.repository.ts

@@ -82,7 +82,7 @@ export class SequelizeRoomUserRepository {
   }
 
   async deleteByUserIdAndRoomId(userId: string, roomId: string): Promise<void> {
-    await this.roomUserModel.destroy({ where: { userId, roomId } });
+    await this.roomUserModel.destroy({ where: { id: userId, roomId } });
   }
 
   async findByParticipantIdAndRoomId(

src/modules/call/services/call.service.spec.ts

@@ -46,14 +46,14 @@
 
   it('When the user has meet enabled, then a call should be created', async () => {
     const userPayload = mockUserPayload;
     jest.spyOn(paymentService, 'getUserTier').mockResolvedValue({
       featuresPerService: {
         meet: {
           enabled: true,
           paxPerCall: 10,
         },
       },
     } as Tier);
 
     (uuid.v4 as jest.Mock).mockReturnValue('test-room-id');
     (jwt.sign as jest.Mock).mockReturnValue('test-jitsi-token');
@@ -71,14 +71,14 @@
 
   it('When the user does not have meet enabled, then an error indicating so is thrown', async () => {
     const userPayload = mockUserPayload;
     jest.spyOn(paymentService, 'getUserTier').mockResolvedValue({
       featuresPerService: {
         meet: {
           enabled: false,
           paxPerCall: 0,
         },
       },
     } as Tier);
 
     await expect(callService.createCall(userPayload)).rejects.toThrow(
       UnauthorizedException,
@@ -86,4 +86,21 @@
 
     expect(paymentService.getUserTier).toHaveBeenCalledWith(userPayload.uuid);
   });
+
+   it('When the user has meet enabled and isDevelopment, then a call should be created without calling payment service', async () => {
+    jest.spyOn(configService, 'get').mockReturnValueOnce(false);
+    const userPayload = mockUserPayload;
+    (uuid.v4 as jest.Mock).mockReturnValue('test-room-id');
+    (jwt.sign as jest.Mock).mockReturnValue('test-jitsi-token');
+
+    const result = await callService.createCall(userPayload);
+
+    expect(result).toEqual({
+      appId: 'jitsi-app-id',
+      room: 'test-room-id',
+      paxPerCall: 10,
+    });
+
+    expect(paymentService.getUserTier).not.toHaveBeenCalled();
+  });
 });

src/modules/call/services/call.service.ts

@@ -48,6 +48,13 @@ export class CallService {
   private async getMeetFeatureConfigForUser(
     userUuid: string,
   ): Promise<Tier['featuresPerService']['meet']> {
+    const isProduction = this.configService.get<boolean>('isProduction');
+    if (!isProduction) {
+      return {
+        enabled: true,
+        paxPerCall: 10,
+      };
+    }
     const userFeatures = await this.paymentService
       .getUserTier(userUuid)
       .catch((err) => {

src/modules/call/services/room.service.ts

@@ -157,22 +157,10 @@ export class RoomService {
         { transaction, lock: true },
       );
 
-      if (existingUser) {
-        if (existingUser.participantId) {
+      if (existingUser?.participantId) {
           oldParticipantId = existingUser.participantId;
-        }
-
-        await this.roomUserRepository.update(
-          existingUser.id,
-          {
-            participantId: null,
-            joinedAt: null,
-          },
-          transaction,
-        );
+      }
 
-        roomUser = existingUser;
-      } else {
         roomUser = await this.roomUserRepository.create(
           {
             roomId,
@@ -183,7 +171,6 @@ export class RoomService {
           },
           transaction,
         );
-      }
     });
 
     return { roomUser, oldParticipantId };