Skip to content

[PB-3514]:feat/implement BaseDialog UI component#1895

Merged
jaaaaavier merged 4 commits intofeature-PB3510-releasefrom
feat/ui-base-dialog
Apr 9, 2026
Merged

[PB-3514]:feat/implement BaseDialog UI component#1895
jaaaaavier merged 4 commits intofeature-PB3510-releasefrom
feat/ui-base-dialog

Conversation

@jaaaaavier
Copy link
Copy Markdown
Contributor

@jaaaaavier jaaaaavier commented Mar 25, 2026

Description

Removed the local BaseDialog component (src/components/BaseDialog.tsx) in favor of the one provided by @internxt/ui
Updated all consumers to import BaseDialog (and Button where applicable) from @internxt/ui instead of components/BaseDialog
Removed the BaseDialog re-export from src/components/index.ts

Related Issues

Related Pull Requests

ui/feat/base-dialog-padding-update

Checklist

  • Changes have been tested locally.
  • Unit tests have been written or updated as necessary.
  • The code adheres to the repository's coding standards.
  • Relevant documentation has been added or updated.
  • No new warnings or errors have been introduced.
  • SonarCloud issues have been reviewed and addressed.
  • QA Passed

Testing Process

Activated the dialogs manually and checked the component work as expected

Additional Notes

image image image m7nFu iuG3Z ln4Zz

Attached 6 images @CandelR , the components we update, tested the component with this branch and the master one. Also attached one more image because the isSharedTooBigDialog is wrong, i created the PR on the UI repo

@jaaaaavier jaaaaavier self-assigned this Mar 25, 2026
@jaaaaavier jaaaaavier added the enhancement New feature or request label Mar 25, 2026
@jaaaaavier jaaaaavier marked this pull request as ready for review March 25, 2026 12:49
Copy link
Copy Markdown
Collaborator

@CandelR CandelR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you attach screenshots in Additionl Notes section with the before and now? :)

@jaaaaavier jaaaaavier requested a review from CandelR March 30, 2026 09:21
@cloudflare-workers-and-pages
Copy link
Copy Markdown

cloudflare-workers-and-pages bot commented Mar 30, 2026

Deploying drive-web with  Cloudflare Pages  Cloudflare Pages

Latest commit: 5e749f3
Status: ✅  Deploy successful!
Preview URL: https://b3a78563.drive-web.pages.dev
Branch Preview URL: https://feat-ui-base-dialog.drive-web.pages.dev

View logs

Copy link
Copy Markdown
Collaborator

@CandelR CandelR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the screenshots! Just a quick question: is the screenshot of ‘unsupported action’ modal okay? The one in the second ‘after’ image looks a bit off, if you’ve got a chance, could you fix that? :)
P.S. If you number the photos or label them with ‘before’ and ‘after’, it’ll be easier to tell them apart and point things out, as in this case :)

@jaaaaavier
Copy link
Copy Markdown
Contributor Author

Thanks for the screenshots! Just a quick question: is the screenshot of ‘unsupported action’ modal okay? The one in the second ‘after’ image looks a bit off, if you’ve got a chance, could you fix that? :) P.S. If you number the photos or label them with ‘before’ and ‘after’, it’ll be easier to tell them apart and point things out, as in this case :)

Mmm okay, i fixed that on the UI repo because is problem from the UI. The images were taken before

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Apr 1, 2026

@jaaaaavier jaaaaavier changed the base branch from master to feature-PB3510-release April 8, 2026 15:59
@jaaaaavier jaaaaavier merged commit ec0eeff into feature-PB3510-release Apr 9, 2026
11 checks passed
@jaaaaavier jaaaaavier deleted the feat/ui-base-dialog branch April 9, 2026 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants