fix: enhance antivirus log routing to support structured log entries …#349
Open
egalvis27 wants to merge 2 commits into
Open
fix: enhance antivirus log routing to support structured log entries …#349egalvis27 wants to merge 2 commits into
egalvis27 wants to merge 2 commits into
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is Changed / Added
This PR fixes antivirus log routing in packaged builds.
Root cause: the previous approach used createRequire(__filename), which could load a different electron-log instance than the one used by @internxt/drive-desktop-core inside the webpack bundle. As a result, overriding resolvePathFn did not affect the active logger.
Solution: replaced that dynamic loading with a static require of the core package’s electron-log module, then applied the resolvePathFn/resolvePath override on that shared instance.
Routing behavior: